Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Immortalize Py_EMPTY_KEYS #104252

Copy link
Copy link
Closed
Closed
Copy link
@ericsnowcurrently

Description

@ericsnowcurrently
Issue body actions

The every dict has a keys "object", of type PyDictKeysObject. While it isn't actually a Python object, it does have a refcount, which is used to know when to free it. PyDictKeysObject (and the helpers, dictkeys_incref() and dictkeys_decref()) was not updated to be immortal when the other singletons were. When it comes to interpreter isolation, that's a problem for empty dicts.

Every empty dict shares a global, statically allocated singleton for its keys: Py_EMPTY_KEYS (AKA static PyDictKeysObject empty_keys_struct). This singleton is defined and used internally in dictobject.c, so we don't have the same ABI compatibility concerns that we have with object ref counts generally,

One way or another, we need to isolate Py_EMPTY_KEYS. Otherwise we end up with races on the refcount.

cc @eduardo-elizondo @markshannon


Possible solutions:

  1. update the code in dictobject.c to make Py_EMPTY_KEYS immortal
  2. move Py_EMPTY_KEYS to PyInterpreterState

The first one seems simpler.

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.12only security fixesonly security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancementA feature request or enhancement

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.