Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e64395e

Browse filesBrowse files
authored
gh-134262: Fix off by one errors in download retry functions (GH-134867)
1 parent e9d845b commit e64395e
Copy full SHA for e64395e

File tree

Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed

‎PCbuild/get_external.py

Copy file name to clipboardExpand all lines: PCbuild/get_external.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
def retrieve_with_retries(download_location, output_path, reporthook,
1313
max_retries=7):
1414
"""Download a file with exponential backoff retry and save to disk."""
15-
for attempt in range(max_retries):
15+
for attempt in range(max_retries + 1):
1616
try:
1717
resp = urlretrieve(
1818
download_location,

‎Tools/build/generate_sbom.py

Copy file name to clipboardExpand all lines: Tools/build/generate_sbom.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def download_with_retries(download_location: str,
169169
base_delay: float = 2.25,
170170
max_jitter: float = 1.0) -> typing.Any:
171171
"""Download a file with exponential backoff retry."""
172-
for attempt in range(max_retries):
172+
for attempt in range(max_retries + 1):
173173
try:
174174
resp = urllib.request.urlopen(download_location)
175175
except urllib.error.URLError as ex:

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.