python
diff --git a/‎Lib/logging/handlers.py
Copy file name to clipboardExpand all lines: Lib/logging/handlers.py
+3-3Lines changed: 3 additions & 3 deletions b/‎Lib/logging/handlers.py
Copy file name to clipboardExpand all lines: Lib/logging/handlers.py
+3-3Lines changed: 3 additions & 3 deletions
diff --git a/‎Misc/NEWS.d/next/Library/2023-06-17-09-07-06.gh-issue-105623.5G06od.rst
Copy file name to clipboard
+2Lines changed: 2 additions & 0 deletions b/‎Misc/NEWS.d/next/Library/2023-06-17-09-07-06.gh-issue-105623.5G06od.rst
Copy file name to clipboard
+2Lines changed: 2 additions & 0 deletions
@@ -193,15 +193,15 @@ def shouldRollover(self, record):
         Basically, see if the supplied record would cause the file to exceed
         the size limit we have.
         """
-        # See bpo-45401: Never rollover anything other than regular files
-        if os.path.exists(self.baseFilename) and not os.path.isfile(self.baseFilename):
-            return False
         if self.stream is None:                 # delay was set...
             self.stream = self._open()
         if self.maxBytes > 0:                   # are we rolling over?
             msg = "%s\n" % self.format(record)
             self.stream.seek(0, 2)  #due to non-posix-compliant Windows feature
             if self.stream.tell() + len(msg) >= self.maxBytes:
+                # See bpo-45401: Never rollover anything other than regular files
+                if os.path.exists(self.baseFilename) and not os.path.isfile(self.baseFilename):
+                    return False
                 return True
         return False
 
 
@@ -0,0 +1,2 @@
+Fix performance degradation in
+:class:`logging.handlers.RotatingFileHandler`. Patch by Craig Robson.
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Fix performance degradation in`
	`2`	+:class:`logging.handlers.RotatingFileHandler`. Patch by Craig Robson.