Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit dc8ce8e

Browse filesBrowse files
bpo-41004: Resolve hash collisions for IPv4Interface and IPv6Interface (GH-21033)
The __hash__() methods of classes IPv4Interface and IPv6Interface had issue of generating constant hash values of 32 and 128 respectively causing hash collisions. The fix uses the hash() function to generate hash values for the objects instead of XOR operation (cherry picked from commit b30ee26) Co-authored-by: Ravi Teja P <rvteja92@gmail.com>
1 parent 7731139 commit dc8ce8e
Copy full SHA for dc8ce8e

File tree

3 files changed

+15
-2
lines changed
Filter options

3 files changed

+15
-2
lines changed

‎Lib/ipaddress.py

Copy file name to clipboardExpand all lines: Lib/ipaddress.py
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1370,7 +1370,7 @@ def __lt__(self, other):
13701370
return False
13711371

13721372
def __hash__(self):
1373-
return self._ip ^ self._prefixlen ^ int(self.network.network_address)
1373+
return hash((self._ip, self._prefixlen, int(self.network.network_address)))
13741374

13751375
__reduce__ = _IPAddressBase.__reduce__
13761376

@@ -2017,7 +2017,7 @@ def __lt__(self, other):
20172017
return False
20182018

20192019
def __hash__(self):
2020-
return self._ip ^ self._prefixlen ^ int(self.network.network_address)
2020+
return hash((self._ip, self._prefixlen, int(self.network.network_address)))
20212021

20222022
__reduce__ = _IPAddressBase.__reduce__
20232023

‎Lib/test/test_ipaddress.py

Copy file name to clipboardExpand all lines: Lib/test/test_ipaddress.py
+12Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2053,6 +2053,18 @@ def testsixtofour(self):
20532053
sixtofouraddr.sixtofour)
20542054
self.assertFalse(bad_addr.sixtofour)
20552055

2056+
# issue41004 Hash collisions in IPv4Interface and IPv6Interface
2057+
def testV4HashIsNotConstant(self):
2058+
ipv4_address1 = ipaddress.IPv4Interface("1.2.3.4")
2059+
ipv4_address2 = ipaddress.IPv4Interface("2.3.4.5")
2060+
self.assertNotEqual(ipv4_address1.__hash__(), ipv4_address2.__hash__())
2061+
2062+
# issue41004 Hash collisions in IPv4Interface and IPv6Interface
2063+
def testV6HashIsNotConstant(self):
2064+
ipv6_address1 = ipaddress.IPv6Interface("2001:658:22a:cafe:200:0:0:1")
2065+
ipv6_address2 = ipaddress.IPv6Interface("2001:658:22a:cafe:200:0:0:2")
2066+
self.assertNotEqual(ipv6_address1.__hash__(), ipv6_address2.__hash__())
2067+
20562068

20572069
if __name__ == '__main__':
20582070
unittest.main()
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
The __hash__() methods of ipaddress.IPv4Interface and ipaddress.IPv6Interface incorrectly generated constant hash values of 32 and 128 respectively. This resulted in always causing hash collisions. The fix uses hash() to generate hash values for the tuple of (address, mask length, network address).

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.