Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit be419ed

Browse filesBrowse files
committed
tests: polish
1 parent f32d32e commit be419ed
Copy full SHA for be419ed

File tree

Expand file treeCollapse file tree

1 file changed

+16
-15
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+16
-15
lines changed

‎Lib/test/test_concurrent_futures/executor.py

Copy file name to clipboardExpand all lines: Lib/test/test_concurrent_futures/executor.py
+16-15Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -74,40 +74,41 @@ def test_map_timeout(self):
7474
self.assertEqual([None, None], results)
7575

7676
def test_map_with_buffersize(self):
77+
iterable = range(4)
7778
with self.assertRaisesRegex(ValueError, "buffersize must be None or >= 1."):
78-
self.executor.map(bool, [], buffersize=0)
79-
80-
it = range(4)
79+
self.executor.map(bool, iterable, buffersize=0)
80+
self.assertEqual(
81+
list(self.executor.map(str, iterable, buffersize=1)),
82+
list(map(str, iterable)),
83+
)
8184
self.assertEqual(
82-
list(self.executor.map(str, it, buffersize=1)),
83-
list(map(str, it)),
85+
list(self.executor.map(str, iterable, buffersize=2)),
86+
list(map(str, iterable)),
8487
)
8588

8689
def test_map_with_buffersize_and_timeout(self):
87-
it = self.executor.map(time.sleep, (0, 1), timeout=0.5)
88-
next(it)
90+
results = self.executor.map(time.sleep, (0, 1), timeout=0.5)
91+
next(results)
8992
with self.assertRaises(TimeoutError):
90-
next(it)
93+
next(results)
9194

9295
def test_map_with_buffersize_on_infinite_iterable(self):
9396
results = self.executor.map(str, itertools.count(1), buffersize=1)
9497
self.assertEqual(next(iter(results)), "1")
9598

9699
def test_map_with_buffersize_on_iterable_smaller_than_buffer(self):
97-
it = range(2)
98-
results = self.executor.map(str, it, buffersize=10)
99-
self.assertListEqual(list(results), list(map(str, it)))
100+
iterable = range(2)
101+
results = self.executor.map(str, iterable, buffersize=8)
102+
self.assertListEqual(list(results), list(map(str, iterable)))
100103

101104
def test_map_with_buffersize_on_empty_iterable(self):
102-
it = iter([])
103-
results = self.executor.map(str, it, buffersize=10)
105+
results = self.executor.map(str, [], buffersize=8)
104106
self.assertListEqual(list(results), [])
105107

106108
def test_map_with_buffersize_when_buffer_becomes_full(self):
107-
manager = multiprocessing.Manager()
108109
iterable = range(8)
109110
buffersize = 4
110-
buffered_results = manager.list()
111+
buffered_results = multiprocessing.Manager().list()
111112
self.executor.map(buffered_results.append, iterable, buffersize=buffersize)
112113
self.executor.shutdown(wait=True)
113114
self.assertSetEqual(

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.