Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b98e779

Browse filesBrowse files
authored
[3.7] bpo-41004: Resolve hash collisions for IPv4Interface and IPv6Interface (GH-21033) (GH-21231)
CVE-2020-14422 The __hash__() methods of classes IPv4Interface and IPv6Interface had issue of generating constant hash values of 32 and 128 respectively causing hash collisions. The fix uses the hash() function to generate hash values for the objects instead of XOR operation (cherry picked from commit b30ee26) Co-authored-by: Ravi Teja P <rvteja92@gmail.com> Signed-off-by: Tapas Kundu <tkundu@vmware.com>
1 parent 4fdc175 commit b98e779
Copy full SHA for b98e779

File tree

3 files changed

+14
-2
lines changed
Filter options

3 files changed

+14
-2
lines changed

‎Lib/ipaddress.py

Copy file name to clipboardExpand all lines: Lib/ipaddress.py
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1442,7 +1442,7 @@ def __lt__(self, other):
14421442
return False
14431443

14441444
def __hash__(self):
1445-
return self._ip ^ self._prefixlen ^ int(self.network.network_address)
1445+
return hash((self._ip, self._prefixlen, int(self.network.network_address)))
14461446

14471447
__reduce__ = _IPAddressBase.__reduce__
14481448

@@ -2088,7 +2088,7 @@ def __lt__(self, other):
20882088
return False
20892089

20902090
def __hash__(self):
2091-
return self._ip ^ self._prefixlen ^ int(self.network.network_address)
2091+
return hash((self._ip, self._prefixlen, int(self.network.network_address)))
20922092

20932093
__reduce__ = _IPAddressBase.__reduce__
20942094

‎Lib/test/test_ipaddress.py

Copy file name to clipboardExpand all lines: Lib/test/test_ipaddress.py
+11Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2091,6 +2091,17 @@ def testsixtofour(self):
20912091
sixtofouraddr.sixtofour)
20922092
self.assertFalse(bad_addr.sixtofour)
20932093

2094+
# issue41004 Hash collisions in IPv4Interface and IPv6Interface
2095+
def testV4HashIsNotConstant(self):
2096+
ipv4_address1 = ipaddress.IPv4Interface("1.2.3.4")
2097+
ipv4_address2 = ipaddress.IPv4Interface("2.3.4.5")
2098+
self.assertNotEqual(ipv4_address1.__hash__(), ipv4_address2.__hash__())
2099+
2100+
# issue41004 Hash collisions in IPv4Interface and IPv6Interface
2101+
def testV6HashIsNotConstant(self):
2102+
ipv6_address1 = ipaddress.IPv6Interface("2001:658:22a:cafe:200:0:0:1")
2103+
ipv6_address2 = ipaddress.IPv6Interface("2001:658:22a:cafe:200:0:0:2")
2104+
self.assertNotEqual(ipv6_address1.__hash__(), ipv6_address2.__hash__())
20942105

20952106
if __name__ == '__main__':
20962107
unittest.main()
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
CVE-2020-14422: The __hash__() methods of ipaddress.IPv4Interface and ipaddress.IPv6Interface incorrectly generated constant hash values of 32 and 128 respectively. This resulted in always causing hash collisions. The fix uses hash() to generate hash values for the tuple of (address, mask length, network address).

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.