Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit a90863c

Browse filesBrowse files
mgornyzware
mgorny
and
zware
authored
gh-100220: Fix error handling in make rules (GH-100328)
Set `SHELL = /bin/sh -e` to ensure that complex recipes fail on the first error rather than incorrectly reporting success. Co-authored-by: Zachary Ware <zach@python.org>
1 parent 2667452 commit a90863c
Copy full SHA for a90863c

File tree

2 files changed

+5
-1
lines changed
Filter options

2 files changed

+5
-1
lines changed

‎Makefile.pre.in

Copy file name to clipboardExpand all lines: Makefile.pre.in
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ DSYMUTIL_PATH= @DSYMUTIL_PATH@
5959
GNULD= @GNULD@
6060

6161
# Shell used by make (some versions default to the login shell, which is bad)
62-
SHELL= /bin/sh
62+
SHELL= /bin/sh -e
6363

6464
# Use this to make a link between python$(VERSION) and python in $(BINDIR)
6565
LN= @LN@

‎Misc/NEWS.d/next/Build/2022-12-18-07-24-44.gh-issue-100220.BgSV7C.rst

Copy file name to clipboard
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Changed the default value of the ``SHELL`` Makefile variable from ``/bin/sh``
2+
to ``/bin/sh -e`` to ensure that complex recipes correctly fail after an error.
3+
Previously, ``make install`` could fail to install some files and yet return
4+
a successful result.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.