Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 767c89b

Browse filesBrowse files
gh-58956: Fix a frame refleak in bdb (#128190)
1 parent d7f703d commit 767c89b
Copy full SHA for 767c89b

File tree

3 files changed

+54
-0
lines changed
Filter options

3 files changed

+54
-0
lines changed

‎Lib/bdb.py

Copy file name to clipboardExpand all lines: Lib/bdb.py
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -404,6 +404,7 @@ def set_trace(self, frame=None):
404404
frame.f_trace_lines = True
405405
frame = frame.f_back
406406
self.set_stepinstr()
407+
self.enterframe = None
407408
sys.settrace(self.trace_dispatch)
408409

409410
def set_continue(self):
@@ -423,6 +424,7 @@ def set_continue(self):
423424
for frame, (trace_lines, trace_opcodes) in self.frame_trace_lines_opcodes.items():
424425
frame.f_trace_lines, frame.f_trace_opcodes = trace_lines, trace_opcodes
425426
self.frame_trace_lines_opcodes = {}
427+
self.enterframe = None
426428

427429
def set_quit(self):
428430
"""Set quitting attribute to True.

‎Lib/test/test_pdb.py

Copy file name to clipboardExpand all lines: Lib/test/test_pdb.py
+51Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3009,6 +3009,57 @@ def test_pdb_f_trace_lines():
30093009
(Pdb) continue
30103010
"""
30113011

3012+
def test_pdb_frame_refleak():
3013+
"""
3014+
pdb should not leak reference to frames
3015+
3016+
>>> def frame_leaker(container):
3017+
... import sys
3018+
... container.append(sys._getframe())
3019+
... import pdb; pdb.Pdb(nosigint=True, readrc=False).set_trace()
3020+
... pass
3021+
3022+
>>> def test_function():
3023+
... import gc
3024+
... container = []
3025+
... frame_leaker(container) # c
3026+
... print(len(gc.get_referrers(container[0])))
3027+
... container = []
3028+
... frame_leaker(container) # n c
3029+
... print(len(gc.get_referrers(container[0])))
3030+
... container = []
3031+
... frame_leaker(container) # r c
3032+
... print(len(gc.get_referrers(container[0])))
3033+
3034+
>>> with PdbTestInput([ # doctest: +NORMALIZE_WHITESPACE
3035+
... 'continue',
3036+
... 'next',
3037+
... 'continue',
3038+
... 'return',
3039+
... 'continue',
3040+
... ]):
3041+
... test_function()
3042+
> <doctest test.test_pdb.test_pdb_frame_refleak[0]>(4)frame_leaker()
3043+
-> import pdb; pdb.Pdb(nosigint=True, readrc=False).set_trace()
3044+
(Pdb) continue
3045+
1
3046+
> <doctest test.test_pdb.test_pdb_frame_refleak[0]>(4)frame_leaker()
3047+
-> import pdb; pdb.Pdb(nosigint=True, readrc=False).set_trace()
3048+
(Pdb) next
3049+
> <doctest test.test_pdb.test_pdb_frame_refleak[0]>(5)frame_leaker()
3050+
-> pass
3051+
(Pdb) continue
3052+
1
3053+
> <doctest test.test_pdb.test_pdb_frame_refleak[0]>(4)frame_leaker()
3054+
-> import pdb; pdb.Pdb(nosigint=True, readrc=False).set_trace()
3055+
(Pdb) return
3056+
--Return--
3057+
> <doctest test.test_pdb.test_pdb_frame_refleak[0]>(5)frame_leaker()->None
3058+
-> pass
3059+
(Pdb) continue
3060+
1
3061+
"""
3062+
30123063
def test_pdb_function_break():
30133064
"""Testing the line number of break on function
30143065
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixed a frame reference leak in :mod:`bdb`.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.