Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6f1f871

Browse filesBrowse files
[3.14] gh-127146: xfail more Emscripten stack overflows (GH-134358) (#134382)
Adds some additional test xfails for Emscripten stack overflows. Also corrects a test skip for test_io. (cherry picked from commit 91e6a58) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
1 parent a2950d5 commit 6f1f871
Copy full SHA for 6f1f871

File tree

Expand file treeCollapse file tree

5 files changed

+6
-1
lines changed
Filter options
Expand file treeCollapse file tree

5 files changed

+6
-1
lines changed

‎Lib/test/test_builtin.py

Copy file name to clipboardExpand all lines: Lib/test/test_builtin.py
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1120,6 +1120,7 @@ def test_filter_pickle(self):
11201120
self.check_iter_pickle(f1, list(f2), proto)
11211121

11221122
@support.skip_wasi_stack_overflow()
1123+
@support.skip_emscripten_stack_overflow()
11231124
@support.requires_resource('cpu')
11241125
def test_filter_dealloc(self):
11251126
# Tests recursive deallocation of nested filter objects using the

‎Lib/test/test_capi/test_misc.py

Copy file name to clipboardExpand all lines: Lib/test/test_capi/test_misc.py
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -412,10 +412,12 @@ def test_trashcan_subclass(self):
412412
L = MyList((L,))
413413

414414
@support.requires_resource('cpu')
415+
@support.skip_emscripten_stack_overflow()
415416
def test_trashcan_python_class1(self):
416417
self.do_test_trashcan_python_class(list)
417418

418419
@support.requires_resource('cpu')
420+
@support.skip_emscripten_stack_overflow()
419421
def test_trashcan_python_class2(self):
420422
from _testcapi import MyList
421423
self.do_test_trashcan_python_class(MyList)

‎Lib/test/test_descr.py

Copy file name to clipboardExpand all lines: Lib/test/test_descr.py
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4523,6 +4523,7 @@ class Oops(object):
45234523
del o
45244524

45254525
@support.skip_wasi_stack_overflow()
4526+
@support.skip_emscripten_stack_overflow()
45264527
@support.requires_resource('cpu')
45274528
def test_wrapper_segfault(self):
45284529
# SF 927248: deeply nested wrappers could cause stack overflow

‎Lib/test/test_exceptions.py

Copy file name to clipboardExpand all lines: Lib/test/test_exceptions.py
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1429,6 +1429,7 @@ def g():
14291429
self.assertIn("maximum recursion depth exceeded", str(exc))
14301430

14311431
@support.skip_wasi_stack_overflow()
1432+
@support.skip_emscripten_stack_overflow()
14321433
@cpython_only
14331434
@support.requires_resource('cpu')
14341435
def test_trashcan_recursion(self):

‎Lib/test/test_io.py

Copy file name to clipboardExpand all lines: Lib/test/test_io.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@ def do_test(test, obj, abilities):
572572
for [test, abilities] in tests:
573573
with self.subTest(test):
574574
if test == pipe_writer and not threading_helper.can_start_thread:
575-
skipTest()
575+
self.skipTest("Need threads")
576576
with test() as obj:
577577
do_test(test, obj, abilities)
578578

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.