Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 30b4e9f

Browse filesBrowse files
authored
gh-119050: Add type hints to libregrtest/results.py (#119144)
Sort also 'omitted' in TestResults.display_result().
1 parent c141d43 commit 30b4e9f
Copy full SHA for 30b4e9f

File tree

1 file changed

+6
-6
lines changed
Filter options

1 file changed

+6
-6
lines changed

‎Lib/test/libregrtest/results.py

Copy file name to clipboardExpand all lines: Lib/test/libregrtest/results.py
+6-6Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919

2020
class TestResults:
21-
def __init__(self):
21+
def __init__(self) -> None:
2222
self.bad: TestList = []
2323
self.good: TestList = []
2424
self.rerun_bad: TestList = []
@@ -38,22 +38,22 @@ def __init__(self):
3838
# used by -T with -j
3939
self.covered_lines: set[Location] = set()
4040

41-
def is_all_good(self):
41+
def is_all_good(self) -> bool:
4242
return (not self.bad
4343
and not self.skipped
4444
and not self.interrupted
4545
and not self.worker_bug)
4646

47-
def get_executed(self):
47+
def get_executed(self) -> set[TestName]:
4848
return (set(self.good) | set(self.bad) | set(self.skipped)
4949
| set(self.resource_denied) | set(self.env_changed)
5050
| set(self.run_no_tests))
5151

52-
def no_tests_run(self):
52+
def no_tests_run(self) -> bool:
5353
return not any((self.good, self.bad, self.skipped, self.interrupted,
5454
self.env_changed))
5555

56-
def get_state(self, fail_env_changed):
56+
def get_state(self, fail_env_changed: bool) -> str:
5757
state = []
5858
if self.bad:
5959
state.append("FAILURE")
@@ -204,7 +204,7 @@ def display_result(self, tests: TestTuple, quiet: bool, print_slowest: bool):
204204
omitted = set(tests) - self.get_executed()
205205

206206
# less important
207-
all_tests.append((omitted, "test", "{} omitted:"))
207+
all_tests.append((sorted(omitted), "test", "{} omitted:"))
208208
if not quiet:
209209
all_tests.append((self.skipped, "test", "{} skipped:"))
210210
all_tests.append((self.resource_denied, "test", "{} skipped (resource denied):"))

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.