You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Re-phrase docs of set_content behavior for str payloads
The previous patch only illustrates this behavior with a
very specific edge case, which IMO did not do a good job
elucidating the present ambiguous documentation, if not
worsening it by obscuring the true intention behind EOL
canonicalization for messages of text/* types.
This instead should address the more general case, abeit less
concrete, which seems like a fair compromise, considering
users who care about accurate representation of line endings
will likely carefully study the documentation and be assured
that this is an expected deviation from the legacy API, while
those who do not are not befuddled by a footnote that seems
to warn of something out of the blue. I do not know if this
is true to the original author's intention, but it is my
personal understanding of this implementation at least. :/
The case of bytes is also addressed briefly in a subsequent
bullet point to assure the user that it is to be expected that
all bytes are preserved as any arbitrary binary file ought to
be. I wish I could state this more explicitly, but that seems
rather hard without presumably restructuring this particular
page, so I will leave it to the original author... :)
Signed-off-by: Yizheng Meng <dev@rapidcow.org>
0 commit comments