Added Example(learning github) #2325
Conversation
for more information, see https://pre-commit.ci
| <title>Shiny Sound</title> | ||
|
|
||
| <!-- Recommended meta tags --> | ||
| <meta charset="UTF-8" /> |
There was a problem hiding this comment.
FYI /> has no meaning in HTML, it has meanings in XHTML and XML (or JSX) but not in HTML so you never need the self closing tag because void elements never need that.
I know this is common misconception out there, I just wanted to point that out since the purpose of this PR is to learn 🙂
There was a problem hiding this comment.
I copied the code from pyscript.com why is it not changed over there?
There was a problem hiding this comment.
I've just created a new project in there and this is what I see:
|
we have |
There was a problem hiding this comment.
When CI fixes something (in this case it's prettier) you should git pull from this branch to update your local version with those fixes back/applied.
There is a major comment around where tests should go and a "nitpick" around the fact something is not really needed.
I am adding this review as part of the "learning" process, so that this PR cannot move forward until comments or other things are either agreed or approved as change.
|
FYI to rebase this branch you can follow command line instruction or To configure upstream: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/configuring-a-remote-repository-for-a-fork |
Description
Changes
Checklist
make buildworks locally.