Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Ignore leading underscores in private methods for camelCase style #10228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 11, 2025
Merged

Ignore leading underscores in private methods for camelCase style #10228

merged 5 commits into from
Feb 11, 2025
+13 −5

Conversation

alexprabhat99
Copy link
Contributor

Type of Changes

Type
✓ 🐛 Bug fix

Description

Refs #XXXX

Closes #10189

@alexprabhat99 alexprabhat99 changed the title Accept leading underscores in private methods for camelCase style Ignore leading underscores in private methods for camelCase style Feb 11, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.84%. Comparing base (3f99fe7) to head (e50f7c8).
⚠️ Report is 332 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10228   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         175      175           
  Lines       19058    19058           
=======================================
  Hits        18266    18266           
  Misses        792      792
Files with missing lines Coverage Δ
pylint/checkers/base/name_checker/naming_style.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@Pierre-Sassoulas Pierre-Sassoulas added False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/4.0.x labels Feb 11, 2025
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.3.5 milestone Feb 11, 2025
Pierre-Sassoulas
Pierre-Sassoulas requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thank you ! Just a check I would like to add.

tests/functional/n/namePresetCamelCase.py Show resolved Hide resolved
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! It'll be released in 3.3.5 :)

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) February 11, 2025 11:26
@Pierre-Sassoulas Pierre-Sassoulas merged commit 5c6950c into pylint-dev:main Feb 11, 2025
44 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
@alexprabhat99 @github-actions
Ignore leading underscores in private/protected methods for camelCase…
1468e15 
… style (#10228)

(cherry picked from commit 5c6950c)
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on psycopg:
The following messages are now emitted:

  1. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/be4e811369e446188e3ffd6c000dd32eec594023/psycopg/psycopg/pq/pq_ctypes.py#L559
  2. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/be4e811369e446188e3ffd6c000dd32eec594023/psycopg/psycopg/pq/pq_ctypes.py#L579
  3. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/be4e811369e446188e3ffd6c000dd32eec594023/psycopg/psycopg/pq/pq_ctypes.py#L640
  4. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/be4e811369e446188e3ffd6c000dd32eec594023/psycopg/psycopg/pq/pq_ctypes.py#L736
  5. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/be4e811369e446188e3ffd6c000dd32eec594023/psycopg/psycopg/pq/pq_ctypes.py#L754
  6. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/be4e811369e446188e3ffd6c000dd32eec594023/psycopg/psycopg/pq/pq_ctypes.py#L796
  7. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/be4e811369e446188e3ffd6c000dd32eec594023/psycopg/psycopg/pq/pq_ctypes.py#L1016

The following messages are no longer emitted:

  1. c-extension-no-member:
    Module 'psycopg.pq._pq_ctypes' has no 'PQnoticeReceiver' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects.
    https://github.com/psycopg/psycopg/blob/be4e811369e446188e3ffd6c000dd32eec594023/psycopg/psycopg/pq/pq_ctypes.py#L55
  2. too-many-function-args:
    Too many positional arguments for function call
    https://github.com/psycopg/psycopg/blob/be4e811369e446188e3ffd6c000dd32eec594023/psycopg/psycopg/pq/pq_ctypes.py#L371

This comment was generated for commit e50f7c8

Pierre-Sassoulas pushed a commit that referenced this pull request Feb 11, 2025
@github-actions @alexprabhat99
Ignore leading underscores in private/protected methods for camelCase…
54f9825 
… style (#10228) (#10229)

(cherry picked from commit 5c6950c)

Co-authored-by: Alex Prabhat Bara <alexpbara@gmail.com>
@alexprabhat99 alexprabhat99 deleted the private-method-camel-case-style branch February 20, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees

No one assigned

Labels

Backported False Positive 🦟 A message is emitted but nothing is wrong with the code

Projects

None yet

Milestone

3.3.5

Development

Successfully merging this pull request may close these issues.

When using camel case, private methods with two leading underscores raise invalid-name

2 participants

@alexprabhat99 @Pierre-Sassoulas
Morty Proxy This is a proxified and sanitized view of the page, visit original site.