-
-
Notifications
You must be signed in to change notification settings - Fork 52
Prevent glyphs from bleeding into neighbours in atlas #1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I saw a call to |
@@ -148,7 +148,7 @@ def test_examples_compare(filename, pytestconfig, force_offscreen, mock_time): | ||
stored_img = iio.imread(screenshot_path) | ||
|
||
# assert similarity | ||
atol = 2 | ||
atol = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow. i somewhat don't believe this.....
i was seeing variations in the middle of the k
.... i guess your changes made it more stable for "small font" which I think we were always operating in that limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file validate_blend_dither.png
lost the word "dither" at the very top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that. The example changed, and I thought to just remove that text because the aa is dithered too. Thanks for bringing it back!
... and a few other improvements to the text shader
Alternative to #1001