Manage the bottom of small pages #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
approved these changes
Jun 4, 2022
src/pydata_sphinx_theme/assets/styles/sections/_footer-article.scss
Outdated
Show resolved
Hide resolved
src/pydata_sphinx_theme/assets/styles/sections/_sidebar-secondary.scss
Outdated
Show resolved
Hide resolved
jarrodmillman
approved these changes
Jun 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #56
Fix #497
The display of empty pages was a bit off as the prev-next button were displayed at the end of article instead of the bottom of the page and the footer was always offscreen event if the article content was small than 100vh.
prev-next
I added a flex rule on
bd-contentto always display the footer at the bottom with margin autofooter
I added a container rule so that the body min-height (100vh) is transmitted to the
bd-container__inner. then instead of forcing the height of the sidebars I force theirmax-height.seems to work on a small page: https://pydata-sphinx-theme--694.org.readthedocs.build/en/694/demo/no-sidebar.html
and don't disturb long one: https://pydata-sphinx-theme--694.org.readthedocs.build/en/694/demo/kitchen-sink/paragraph-markup.html