Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

alexmojaki
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Oct 9, 2025

Docs Preview

commit: cb92a4c
Preview URL: https://bd9e2330-pydantic-ai-previews.pydantic.workers.dev

@alexmojaki alexmojaki requested a review from Copilot October 9, 2025 14:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR documents the new InstrumentationSettings(version=3) option for OpenTelemetry semantic conventions compliance, explaining the specific changes it makes to span names and attribute names compared to the default version=2.

  • Documents the new version=3 setting for InstrumentationSettings
  • Lists the specific span and attribute name changes that occur with version 3
  • Reorganizes the documentation to clarify the difference between version compatibility and naming compliance

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexmojaki alexmojaki requested review from DouweM and Kludex October 9, 2025 14:15
Comment on lines +273 to +274
- The span name `agent run` becomes `invoke_agent {gen_ai.agent.name}` (with the agent name filled in)
- The span name `running tool` becomes `execute_tool {gen_ai.tool.name}` (with the tool name filled in)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the current version tho 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the message doesn't change atm, only the span_name. which may actually cause confusion

@alexmojaki alexmojaki merged commit db93a9c into main Oct 9, 2025
32 checks passed
@alexmojaki alexmojaki deleted the alex/instrumentation-v3-docs branch October 9, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.