Use click instead of argparse on PydanticAI CLI #3080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DouweM Unrelated linting errors to this PR still seem to be showing up. Thought it was an issue with my rebase in my closed PR |
Closed
|
@assadyousuf Looking it |
|
Everything is ready on this PR now |
Kludex
reviewed
Oct 10, 2025
pydantic_ai_slim/pyproject.toml
Outdated
| cli = [ | ||
| "rich>=13", | ||
| "prompt-toolkit>=3", | ||
| "argcomplete>=3.5.0", |
There was a problem hiding this comment.
I think this dependency was dropped?
There was a problem hiding this comment.
You're right missed this
pydantic_ai_slim/pydantic_ai/_cli.py
Outdated
| sys.exit(cli(prog_name=prog_name)) | ||
|
|
||
|
|
||
| def cli( # noqa: C901 |
There was a problem hiding this comment.
Is this factory still needed like this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1702