fix klucher spelling

pvlib · wholmgren · Mar 9, 2016 · Oct 28, 2015 · Oct 28, 2015 · Oct 28, 2015
commit b9d41c81aae3fd76caa211a703aad9d1c848cb0f
diff --git a/docs/sphinx/source/whatsnew/v0.2.2.txt b/docs/sphinx/source/whatsnew/v0.2.2.txt
@@ -17,6 +17,11 @@ Enhancements
 Bug fixes
 ~~~~~~~~~

+* ``irradiance.total_irrad`` had a typo that required the
+  Klucher model to be accessed with ``'klutcher'``. Both spellings will work
+  for the remaining 0.2.* versions of pvlib,
+  but the misspelled method will be removed in 0.3.
+  (:issue:`97`)
 * Fixes an import and KeyError in the IPython notebook tutorials
  (:issue:`94`).
 * Uses the ``logging`` module properly by replacing ``format``

diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py
@@ -376,7 +376,7 @@ def total_irrad(surface_tilt, surface_azimuth,
    model = model.lower()
    if model == 'isotropic':
        sky = isotropic(surface_tilt, dhi)
-    elif model == 'klutcher':
+    elif model in ['klucher', 'klutcher']:
        sky = klucher(surface_tilt, surface_azimuth, dhi, ghi,
                      solar_zenith, solar_azimuth)
    elif model == 'haydavies':
-Original file line number
+Diff line change
@@ -376,7 +376,7 @@ def total_irrad(surface_tilt, surface_azimuth,
         model = model.lower()
         if model == 'isotropic':
             sky = isotropic(surface_tilt, dhi)
-        elif model == 'klutcher':
+        elif model in ['klucher', 'klutcher']:
               Copy link

  
        
      
    

    
        

  
    Contributor


        

    
  

  
    
      
          
      

      
            alorenzo175
  

      

      

      


        Nov 17, 2015


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Should probably put a deprecation warning here if the old spelling is used.
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



    
        
  
    
      
          
    
  


        
            
  
      
              Copy link

  
        
      
    

    
        

  
  Member


        

  Author


    
  

  
    
      
          
      

      
            wholmgren
  

      

      

      


        Nov 17, 2015


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      This was already merged in #100 and then I rebased after the 0.2.2 release, so I didn't expect this to show up on the diff. Maybe I should have merged 0.2.2 into my branch instead of rebased.
The deprecation warning probably would have been nicer.
    
  
  



    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
             sky = klucher(surface_tilt, surface_azimuth, dhi, ghi,
                           solar_zenith, solar_azimuth)
         elif model == 'haydavies':
-          Expand Down