Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Combine read_nsrdb_psm4 and parse_nsrdb_psm4 #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 7, 2025

Conversation

kandersolar
Copy link
Member

  • Partially addresses Consider removing the parse_ iotools functions #2444
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

As proposed in #2444. I also cleaned up some unrelated docs cruft; sorry for the noise.

@kandersolar kandersolar added this to the v0.12.1 milestone Apr 23, 2025
@kandersolar kandersolar added the remote-data triggers --remote-data pytests label Apr 23, 2025
pvlib/iotools/psm4.py Outdated Show resolved Hide resolved
pvlib/iotools/psm4.py Outdated Show resolved Hide resolved
pvlib/iotools/psm4.py Outdated Show resolved Hide resolved
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great stuff!

docs/sphinx/source/whatsnew/v0.12.1.rst Outdated Show resolved Hide resolved
pvlib/iotools/psm4.py Outdated Show resolved Hide resolved
pvlib/iotools/psm4.py Outdated Show resolved Hide resolved
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
@kandersolar kandersolar added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Apr 30, 2025
@kandersolar kandersolar merged commit 2093264 into pvlib:main May 7, 2025
24 of 25 checks passed
@kandersolar kandersolar deleted the no_more_parse branch May 7, 2025 11:52
@kandersolar kandersolar modified the milestones: v0.12.1, v0.13.0 Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.