Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Python Flake8 linter workflow to replace stickler-ci #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kandersolar merged 30 commits into from
Jul 31, 2023
Merged

Python Flake8 linter workflow to replace stickler-ci #1786

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
f23d95b
adding flake8 linter workflow
reepoi Jun 26, 2023
251a6d9
lint only changed files
reepoi Jun 26, 2023
ebf4868
move changed files to env variable
reepoi Jun 26, 2023
93fccc5
remove filename flag
reepoi Jun 26, 2023
c58095f
remove trailing dot
reepoi Jun 26, 2023
232f505
rename job
reepoi Jun 26, 2023
e064e2c
pass filenames as positional arguments
reepoi Jun 26, 2023
cbc1232
pipe filenames to xargs
reepoi Jun 26, 2023
3513b52
change to check pvlib repo
reepoi Jun 26, 2023
0023272
only lint python files
reepoi Jun 26, 2023
5d9d48e
missing parenthesis
reepoi Jun 26, 2023
8c6c36a
skip linting if no Python files edited
reepoi Jun 26, 2023
db298fb
try env instead of output
reepoi Jun 26, 2023
bed3304
reformatting
reepoi Jun 26, 2023
31cbb3b
create lint issues to try out the new linter
kandersolar Jul 6, 2023
980704b
Revert "create lint issues to try out the new linter"
kandersolar Jul 6, 2023
23700fd
create a lint issue in a file with other lint issues
kandersolar Jul 6, 2023
990d90e
Merge branch 'main' of github.com:pvlib/pvlib-python into stickler-sub
reepoi Jul 12, 2023
b90dfdf
use flake8 --diff with flake8 5.0.4
reepoi Jul 12, 2023
8199b8e
Merge branch 'stickler-sub' of github.com:reepoi/pvlib-python into st…
reepoi Jul 12, 2023
79f7e35
call to git fetch
reepoi Jul 12, 2023
0ada7c4
use GITHUB_TOKEN for fetching
reepoi Jul 12, 2023
dd00e8a
set repository read permission
reepoi Jul 12, 2023
5920174
try using https link to repo instead of ssh
reepoi Jul 12, 2023
fdc65d2
test if GITHUB_TOKEN permissions are not needed
reepoi Jul 12, 2023
043e507
add temporary example of linting annotations
reepoi Jul 12, 2023
1dfbe61
breaking workflow command into more steps
reepoi Jul 19, 2023
302bf35
use base ref variable instead of hard-coding main branch
reepoi Jul 20, 2023
7b6fda9
Merge branch 'main' of github.com:pvlib/pvlib-python into stickler-sub
reepoi Jul 25, 2023
c987ee7
update whatsnew and remove lint error example
reepoi Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test if GITHUB_TOKEN permissions are not needed
  • Loading branch information
@reepoi
reepoi committed Jul 12, 2023
commit fdc65d268f2a66d43a45a476748af7acd8a07c45
6 changes: 1 addition & 5 deletions 6 .github/workflows/flake8.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ on:
jobs:
flake8-linter:
runs-on: ubuntu-latest
permissions:
repository-projects: read
steps:
- name: Checkout source
uses: actions/checkout@v3
Expand All @@ -18,9 +16,7 @@ jobs:
- name: Setup Flake8 output matcher for PR annotations
run: echo '::add-matcher::.github/workflows/flake8-linter-matcher.json'
- name: Run Flake8 linter
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
git remote add upstream https://github.com/pvlib/pvlib-python.git
git fetch upstream main # requires repository-projects read access
git fetch upstream main
git diff upstream/main HEAD | flake8 --exclude pvlib/version.py --ignore E201,E241,E226,W503,W504 --max-line-length 79 --diff
Morty Proxy This is a proxified and sanitized view of the page, visit original site.