Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[bug] use clip instead of abs in singleaxis #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wholmgren merged 8 commits into from
Aug 9, 2021
Merged

[bug] use clip instead of abs in singleaxis #1273

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f37cc32
[bug] use clip instead of abs
mikofski Aug 8, 2021
dcdfcd0
[test] add test using repro steps
mikofski Aug 8, 2021
8a588a3
[sty] fix stickler
mikofski Aug 8, 2021
0cfc794
[test] oops forgot aoi key
mikofski Aug 8, 2021
15b07fe
[test] oops typo tr['aoi'
mikofski Aug 8, 2021
1e0c500
[test] set angles behind fixed to nan
mikofski Aug 8, 2021
e3742d3
[test] use smaller max angle, set nans from tracker
mikofski Aug 8, 2021
15fa20e
[doc] whatsnew singleaxis aoi fix gh1221
mikofski Aug 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[test] set angles behind fixed to nan
  • Loading branch information
@mikofski
mikofski authored Aug 8, 2021
commit 1e0c5008e57df79741f0f57cc3e30e0072f7bc06
3 changes: 2 additions & 1 deletion 3 pvlib/tests/test_tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,4 +515,5 @@ def test_singleaxis_aoi_gh1221():
sp['apparent_zenith'], sp['azimuth'], axis_tilt=90, axis_azimuth=180,
max_angle=0.01, backtrack=False)
fixed = pvlib.irradiance.aoi(90, 180, sp['apparent_zenith'], sp['azimuth'])
assert np.allclose(tr['aoi'], fixed)
fixed[fixed>90] = np.nan
assert np.allclose(tr['aoi'], fixed, equal_nan=True)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.