Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Inconsistent parameter name in fit_sdm_cec_sam()? #958

New issue
Copy link
New issue
Copy link
Open
Open
Inconsistent parameter name in fit_sdm_cec_sam()?#958
Copy link
Labels
api
Milestone
 
Someday
@Peque

Description

@Peque
Peque
opened on Apr 25, 2020
Issue body actions

The parameter beta_voc is named after v_oc.

The parameter alpha_sc is a bit inconsistent with this, since it should be alpha_isc (after i_sc).

In fact, the underlying SAM function also expects that name:

pvlib-python/pvlib/ivtools.py

Lines 95 to 99 in 93adb59

datadict = {'tech_model': '6parsolve', 'financial_model': None,
'celltype': celltype, 'Vmp': v_mp,
'Imp': i_mp, 'Voc': v_oc, 'Isc': i_sc, 'alpha_isc': alpha_sc,
'beta_voc': beta_voc, 'gamma_pmp': gamma_pmp,
'Nser': cells_in_series, 'Tref': temp_ref}

Metadata

Metadata

Assignees

No one assigned

    Labels

    api

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      Morty Proxy This is a proxified and sanitized view of the page, visit original site.