Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

adopt NEP-29 #828

Copy link
Copy link
Closed
Closed
Copy link
@mikofski

Description

@mikofski
Issue body actions

Is your feature request related to a problem? Please describe.
the travis-ci test fails for #823 because the minimum NumPy version for py35-min is version 1.10.4 - the np.roll() function used was updated to allow multiple axes in NumPy-1.12

Describe the solution you'd like
NEP-29 is a proposal by maintainers of IPython, Matplotlib, SciPy, and NumPy that proposes the support window for Python and Numpy.

TL;DR: in the immediate future, drop support for Python-3.5 and Numpy<1.14

Describe alternatives you've considered

  • statically create the 3 rotation matrices, removing the use of np.roll completely
  • use the pre-NumPy-1.12 version of np.roll

Additional context
Since many other major packages that are used by pvlib are conforming to NEP-29, it makes a lot of sense for pvlib to also conform.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.