Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Should ModelChain and PVSystemLocalized both have a future in pvlib? #492

Copy link
Copy link
Closed
@markcampanelli

Description

@markcampanelli
Issue body actions

Is your feature request related to a problem? Please describe.

It is not clear to me what value ModelChain has in comparison to the PVSystemLocalized class.

Describe the solution you'd like

Let's discuss if the codebase can be simplified by removing one or the other of these classes, which appear (at least on the surface) to overlap significantly in purpose, e.g., computing performance for a PVSystem at a given Location.

Describe alternatives you've considered

I'm leaning towards getting rid of ModelChain and making PVSystemLocalized the workhorse, but I really don't know, because I don't really know what workflow might be more popular among users.

Additional context

See the architecture discussion in #487.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.