Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Error in Ixx equation in pvsystem.sapm #2016

Copy link
Copy link
Closed
@cwhanse

Description

@cwhanse
Issue body actions

The SAPM function uses Aisc (temperature coefficient for Isc) in the equation for Ixx, where it should be Aimp (temperature coefficient for Imp). This line.

Equation 10 of the 2004 Sandia report shows Aimp is intended.

Discussion among the Sandia staff concluded that there is a typo in PVLib for Matlab, in this line.

This error was propagated when the Matlab code was ported to python by R. Andrews (see pvl_sapm.py file in the prearizona tag for pvlib).

The comment originated with W. Holmgren, who may have been looking at the Matlab code as the authoritative source.

Expected behavior
Correct this line to use Aimp.

Versions:

  • pvlib.__version__: all versions

Additional context
The error only affects Ixx from pvsystem.sapm and nothing else.

PVLib for Matlab issue sandialabs/MATLAB_PV_LIB#37

adriesse and kandersolar

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.