Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

pvlib.soiling.hsu takes tilt instead of surface_tilt #1717

Copy link
Copy link
Closed
@kandersolar

Description

@kandersolar
Issue body actions

pvlib.soiling.hsu takes a tilt parameter representing the same thing we normally call surface_tilt:

def hsu(rainfall, cleaning_threshold, tilt, pm2_5, pm10,
depo_veloc=None, rain_accum_period=pd.Timedelta('1h')):

tilt : float
Tilt of the PV panels from horizontal. [degree]

I don't see any good reason for this naming inconsistency (I suspect tilt just got copied from the matlab implementation) and suggest we rename the parameter to surface_tilt with a deprecation.

Also, the docstring parameter type description says it must be float, but the model's reference explicitly says time series tilt is allowed:

The angle is variable for tracking systems and is taken as the average angle over the time step.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.