Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove default air temperature and wind speed from ModelChain.run_model etc. #1113

Copy link
Copy link
Open
@cwhanse

Description

@cwhanse
Issue body actions

Currently, ModelChain.run_model requires only irradiance as input. Air temperature and wind speed are optional, and if not provided, pvlib defaults to using 20C and 0m/s respectively. ModelChain method docstrings describe this behavior so it is not hidden from the user.

Although convenient for some use cases, supplying default air temperature and wind speed allows ModelChain.run_model() to complete without error if a user has data for e.g. air temperature in the weather input but not in the temp_air column. This behavior is less explicit than desired, IMO.

Similar concerns with ModelChain.run_model_from_poa and ModelChain.run_model_from_effective_irradiance.

Recommended solution: require air temperature and wind speed as inputs for ModelChain.run_model methods, except in the case where cell_temperature is provided as input.

Alternatives: leave as is.

wholmgren

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.