Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

remove ModelChain.orientation_strategy #1028

Copy link
Copy link
Closed
@wholmgren

Description

@wholmgren
Issue body actions

I don't like that ModelChain(system, location, orientation_strategy='flat|south_at_latitude_tilt) modifies the system object. It's not something we do anywhere else in pvlib. orientation_strategy only supports flat and south_at_latitude_tilt, neither of which are commonly used in the real world in 2020.

I think we should remove it, maybe even without deprecation, in 0.8.

I'm ok with keeping the modelchain.get_orientation function for now.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.