Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit c18c796

Browse filesBrowse files
RDaxinikandersolarechedey-ls
authored
Remove deprecated pvsystem.sapm_spectral_loss (#2244)
* remove from pvsystem.py and test_pvsystem.py * remove from system_models.rst * Update v0.11.3.rst * slight wording change in whatsnew * Update docs/sphinx/source/whatsnew/v0.11.3.rst Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * add ! v0.6.1 and 10.0.0 Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> --------- Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
1 parent 9f5ac3f commit c18c796
Copy full SHA for c18c796

File tree

Expand file treeCollapse file tree

6 files changed

+4
-15
lines changed
Filter options
Expand file treeCollapse file tree

6 files changed

+4
-15
lines changed

‎docs/sphinx/source/reference/pv_modeling/system_models.rst

Copy file name to clipboardExpand all lines: docs/sphinx/source/reference/pv_modeling/system_models.rst
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ Sandia array performance model (SAPM)
1313
pvsystem.sapm
1414
pvsystem.sapm_effective_irradiance
1515
pvsystem.sapm_spectral_loss
16-
spectrum.spectral_factor_sapm
1716
inverter.sandia
1817
temperature.sapm_cell
1918

‎docs/sphinx/source/whatsnew/v0.10.0.rst

Copy file name to clipboardExpand all lines: docs/sphinx/source/whatsnew/v0.10.0.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ Deprecations
5555
* Functions for calculating spectral modifiers have been moved to :py:mod:`pvlib.spectrum`:
5656
:py:func:`!pvlib.atmosphere.first_solar_spectral_correction` is deprecated and
5757
replaced by :py:func:`~pvlib.spectrum.spectral_factor_firstsolar`, and
58-
:py:func:`pvlib.pvsystem.sapm_spectral_loss` is deprecated and replaced by
58+
:py:func:`!pvlib.pvsystem.sapm_spectral_loss` is deprecated and replaced by
5959
:py:func:`~pvlib.spectrum.spectral_factor_sapm`. (:pull:`1628`)
6060
* Removed the ``get_ecmwf_macc`` and ``read_ecmwf_macc`` iotools functions as the
6161
MACC dataset has been `removed by ECMWF <https://confluence.ecmwf.int/display/DAC/Decommissioning+of+ECMWF+Public+Datasets+Service>`_

‎docs/sphinx/source/whatsnew/v0.11.3.rst

Copy file name to clipboardExpand all lines: docs/sphinx/source/whatsnew/v0.11.3.rst
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ Breaking Changes
1212
* Users must now provide ModelChain.spectral_model, or the 'no_loss' spectral
1313
model is assumed. pvlib.modelchain.ModelChain no longer attempts to infer
1414
the spectral model from PVSystem attributes. (:issue:`2017`, :pull:`2253`)
15+
* Remove deprecated :py:func:`!pvlib.pvsystem.sapm_spectral_loss`.
16+
(:issue:`2243`, :pull:`2244`)
1517
* :py:func:`~pvlib.iotools.read_tmy3` now defaults to ``map_variables=True``.
1618
Additionally, the deprecated ``recolumn`` parameter is now removed. (:issue:`2324`, :pull:`2408`)
1719
* Remove :py:func:`!pvlib.atmosphere.first_solar_spectral_correction`, deprecated in v0.10.0.

‎docs/sphinx/source/whatsnew/v0.6.1.rst

Copy file name to clipboardExpand all lines: docs/sphinx/source/whatsnew/v0.6.1.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Enhancements
5656
* Use HRRR modeled surface temperature values instead of inferring from
5757
isobaric values and modeled wind speed instead of inferring from gust.
5858
(:issue:`604`)
59-
* Change :py:func:`pvlib.pvsystem.sapm_spectral_loss` to avoid numpy warning.
59+
* Change :py:func:`!pvlib.pvsystem.sapm_spectral_loss` to avoid numpy warning.
6060
* Add warning message when :py:func:`pvlib.spa` is reloaded. (:issue:`401`)
6161
* Add option for :py:func:`pvlib.irradiance.disc` to use relative airmass
6262
by supplying `pressure=None`. (:issue:`449`)

‎pvlib/pvsystem.py

Copy file name to clipboardExpand all lines: pvlib/pvsystem.py
-6Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2314,12 +2314,6 @@ def sapm(effective_irradiance, temp_cell, module):
23142314
return out
23152315

23162316

2317-
sapm_spectral_loss = deprecated(
2318-
since='0.10.0',
2319-
alternative='pvlib.spectrum.spectral_factor_sapm'
2320-
)(spectrum.spectral_factor_sapm)
2321-
2322-
23232317
def sapm_effective_irradiance(poa_direct, poa_diffuse, airmass_absolute, aoi,
23242318
module):
23252319
r"""

‎tests/test_pvsystem.py

Copy file name to clipboardExpand all lines: tests/test_pvsystem.py
-6Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -234,12 +234,6 @@ def test_PVSystem_multi_array_sapm(sapm_module_params):
234234
system.sapm(500, temp_cell)
235235

236236

237-
def test_sapm_spectral_loss_deprecated(sapm_module_params):
238-
with pytest.warns(pvlibDeprecationWarning,
239-
match='Use pvlib.spectrum.spectral_factor_sapm'):
240-
pvsystem.sapm_spectral_loss(1, sapm_module_params)
241-
242-
243237
def test_PVSystem_sapm_spectral_loss(sapm_module_params, mocker):
244238
mocker.spy(spectrum, 'spectral_factor_sapm')
245239
system = pvsystem.PVSystem(module_parameters=sapm_module_params)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.