Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5cb695d

Browse filesBrowse files
Remove unnecessary **kwargs from spa_python and get_total_irradiance (#1437)
* Update Solarposition.py Removed **kwargs from pvlib.solarposition.spa_python * Added v0.9.2.rst, changes in pvlib/irradiance.py and pvlib/location.py Made new v0.9.2.rst and removed **kwargs from pvlib/irradiance.py (Line 309) and pvlib/location.py (Line 234-235) * Update docs/sphinx/source/whatsnew/v0.9.2.rst * Update docs/sphinx/source/whatsnew/v0.9.2.rst Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>
1 parent 8460b36 commit 5cb695d
Copy full SHA for 5cb695d

File tree

Expand file treeCollapse file tree

4 files changed

+32
-4
lines changed
Filter options
Expand file treeCollapse file tree

4 files changed

+32
-4
lines changed
+29Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
.. _whatsnew_0920:
2+
3+
v0.9.2 (TBD)
4+
-----------------------
5+
6+
Deprecations
7+
~~~~~~~~~~~~
8+
9+
Enhancements
10+
~~~~~~~~~~~~
11+
12+
Bug fixes
13+
~~~~~~~~~
14+
* :py:func:`pvlib.irradiance.get_total_irradiance` and
15+
:py:func:`pvlib.solarposition.spa_python` now raise an error instead
16+
of silently ignoring unknown parameters (:ghpull:`1437`)
17+
18+
Testing
19+
~~~~~~~
20+
21+
Documentation
22+
~~~~~~~~~~~~~
23+
24+
Requirements
25+
~~~~~~~~~~~~
26+
27+
Contributors
28+
~~~~~~~~~~~~
29+
* Naman Priyadarshi (:ghuser:`Naman-Priyadarshi`)

‎pvlib/irradiance.py

Copy file name to clipboardExpand all lines: pvlib/irradiance.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ def get_total_irradiance(surface_tilt, surface_azimuth,
306306
dni, ghi, dhi, dni_extra=None, airmass=None,
307307
albedo=.25, surface_type=None,
308308
model='isotropic',
309-
model_perez='allsitescomposite1990', **kwargs):
309+
model_perez='allsitescomposite1990'):
310310
r"""
311311
Determine total in-plane irradiance and its beam, sky diffuse and ground
312312
reflected components, using the specified sky diffuse irradiance model.

‎pvlib/location.py

Copy file name to clipboardExpand all lines: pvlib/location.py
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,7 @@ def get_clearsky(self, times, model='ineichen', solar_position=None,
231231
pressure = atmosphere.alt2pres(self.altitude)
232232

233233
if solar_position is None:
234-
solar_position = self.get_solarposition(times, pressure=pressure,
235-
**kwargs)
234+
solar_position = self.get_solarposition(times, pressure=pressure)
236235

237236
apparent_zenith = solar_position['apparent_zenith']
238237
apparent_elevation = solar_position['apparent_elevation']

‎pvlib/solarposition.py

Copy file name to clipboardExpand all lines: pvlib/solarposition.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ def _spa_python_import(how):
275275

276276
def spa_python(time, latitude, longitude,
277277
altitude=0, pressure=101325, temperature=12, delta_t=67.0,
278-
atmos_refract=None, how='numpy', numthreads=4, **kwargs):
278+
atmos_refract=None, how='numpy', numthreads=4):
279279
"""
280280
Calculate the solar position using a python implementation of the
281281
NREL SPA algorithm.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.