Add examples of lazy & memoized#747
Merged
thomashoneyman merged 3 commits intopurescript-halogen:masterpurescript-halogen/purescript-halogen:masterfrom Apr 15, 2021
thomashoneyman:memoized-exampleCopy head branch name to clipboard
Merged
Add examples of lazy & memoized#747thomashoneyman merged 3 commits intopurescript-halogen:masterpurescript-halogen/purescript-halogen:masterfrom thomashoneyman:memoized-exampleCopy head branch name to clipboard
thomashoneyman merged 3 commits intopurescript-halogen:masterpurescript-halogen/purescript-halogen:masterfrom
thomashoneyman:memoized-exampleCopy head branch name to clipboard
Conversation
Merged
garyb
approved these changes
Apr 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds examples for the
lazyandmemoizedfunctions. The example works by displaying three results of calling a very poor fibonnaci implementation, with an extra button to toggle the background color of the example. Toggling the background color without memoization leads to extremely slow renders.The first example re-renders any time the state changes, like normal Halogen, and it's quite slow. The second example uses
memoizedwitheq, and it's quite slow because of #742 (but is fixed in #743). The third example useslazyand is quite fast.Here's a demonstration of this example running against
master:master.mov
Notably, the
memoizedexample is still very slow. But if I run this example against thefix-memoizedbranch used in #743 the result is what we'd expect:fix-memoized.mov