Add scope property#718
Merged
thomashoneyman merged 1 commit intopurescript-halogen:masterpurescript-halogen/purescript-halogen:masterfrom Dec 17, 2020
pmiddend:add-scope-propertypmiddend/purescript-halogen:add-scope-propertyCopy head branch name to clipboard
Merged
Add scope property#718thomashoneyman merged 1 commit intopurescript-halogen:masterpurescript-halogen/purescript-halogen:masterfrom pmiddend:add-scope-propertypmiddend/purescript-halogen:add-scope-propertyCopy head branch name to clipboard
thomashoneyman merged 1 commit intopurescript-halogen:masterpurescript-halogen/purescript-halogen:masterfrom
pmiddend:add-scope-propertypmiddend/purescript-halogen:add-scope-propertyCopy head branch name to clipboard
Conversation
garyb
requested changes
Dec 17, 2020
Member
garyb
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I have a suggestion though:
ce0bdbf to
6089699
Compare
Contributor
Author
|
@garyb Thanks for the suggestion and explanation. I changed it accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The halogen guide told me to add any property that's allowed but not in halogen yet.
So here I am, with nextto no knowledge of Purescript and Halogen creating this PR. Be gentle. :)