Read most recent driver state when disposing#676
Merged
thomashoneyman merged 1 commit intopurescript-halogen:masterpurescript-halogen/purescript-halogen:masterfrom Jun 18, 2020
thomashoneyman:dispose-fixCopy head branch name to clipboard
Merged
Read most recent driver state when disposing#676thomashoneyman merged 1 commit intopurescript-halogen:masterpurescript-halogen/purescript-halogen:masterfrom thomashoneyman:dispose-fixCopy head branch name to clipboard
thomashoneyman merged 1 commit intopurescript-halogen:masterpurescript-halogen/purescript-halogen:masterfrom
thomashoneyman:dispose-fixCopy head branch name to clipboard
Conversation
milesfrain
pushed a commit
to milesfrain/purescript-halogen
that referenced
this pull request
Jun 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #675. I noticed while writing up the issue that a call to
disposewill use the driver state it received when the component was first run, and will attempt to dispose the rendered tree at that time. Instead, we need to use the latest driver state when disposing.This PR reads the latest driver state and works correctly in my test case in #675.