Include psc-package sources list in arguments too if being used #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kritzcreek
approved these changes
Aug 18, 2017
psci.el
Outdated
| (apply 'make-comint-in-buffer psci/buffer-name buffer | ||
| psci-program nil psci/arguments) | ||
| (let ((full-arg-list (if (file-exists-p "psc-package.json") | ||
| (let ((psc-package-sources (split-string (shell-command-to-string "psc-package sources")))) |
There was a problem hiding this comment.
Might make sense to extract this into its own function. Something like psci/get-psc-package-sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulp now supports
psc-packageas well as bower to manage packages. If you've initialised a project withpulp --psc-package init, psci is not passed the correct arguments unless you add the big list of output generated bypsc-package sourcesto thepsci/argumentscustom variable.This checks for a
psc-package.jsonin the project root which tends to indicate psc-package is being used, and if it finds one, it adds the output frompsc-package sourcesto the arguments list which seems to allow thepscibuffer to start up again.