Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Use purescript-github-actions-toolkit library #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomashoneyman merged 6 commits into from
Sep 10, 2020
Merged

Use purescript-github-actions-toolkit library #8

thomashoneyman merged 6 commits into from
Sep 10, 2020

Conversation

@colinwahl
Copy link
Member

@colinwahl colinwahl commented Sep 10, 2020 •
edited
Loading

  • Removes the src/Actions tree
  • Adds a the github-actions-toolkit dependency
  • Implements setup-purescript using the external bindings

This intends to close #4

@colinwahl
Copy link
Member Author

colinwahl commented Sep 10, 2020

I'm not sure how to get CI to run on this branch - I have run it on a private copy I have of this repo, but ideally I'd be able to run it here as well.

@colinwahl
Copy link
Member Author

colinwahl commented Sep 10, 2020

I created #9 which I believe will make CI run on the commits to future PRs

thomashoneyman
thomashoneyman reviewed Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests run I’m in! Thanks!

packages.dhall Outdated Show resolved Hide resolved
src/Main.purs Outdated Show resolved Hide resolved
@colinwahl
Copy link
Member Author

colinwahl commented Sep 10, 2020

Aha! Tests are running :)

thomashoneyman
thomashoneyman approved these changes Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to link to these bindings in the README, as they’re worth promoting.

@thomashoneyman thomashoneyman merged commit beee57d into purescript-contrib:main Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Split out bindings to GitHub Actions toolkit as a new library

2 participants

@colinwahl @thomashoneyman
Morty Proxy This is a proxified and sanitized view of the page, visit original site.