Fix math imports; drop Math#80
Fix math imports; drop Math#80JordanMartinez merged 4 commits intopurescript-contrib:mainpurescript-contrib/purescript-formatters:mainfrom JordanMartinez:fix-mathCopy head branch name to clipboard
Conversation
|
Bit of an interesting CI error here. |
|
Huh... Yeah it is. I'll look into it. |
|
The failing test is caused by Nate's changes in Changing this line (https://github.com/purescript-contrib/purescript-formatters/blob/main/src/Data/Formatter/Parser/Interval.purs#L32=) to the following makes the test pass again: - parseInterval duration date = [ startEnd, durationEnd, startDuration, durationOnly ] <#> PC.try #
+ parseInterval duration date = [ startEnd, durationEnd, startDuration, durationOnly ] <#> PC.try # foldl (<|>) emptyConceptually, the parse is the same. The difference is what the final parser is and how that affects the error message: @natefaubion I believe you modified |
|
I think choice should still be right associative. The fact that choice required you to always step through a useless alternative is an odd requirement. |
|
K, I'll update the error message then. |
|
Can I get an approval? |
|
Sorry, I'm not saying that the current error behavior is OK, I'm just saying that I would like to preserve both. I'll need to think about it. |
This reverts commit 854056e.
Description of the change
Drops
math; updates importsChecklist: