[purs ide] Editor mode#3006
Merged
kritzcreek merged 4 commits intopurescript:masterpurescript/purescript:masterfrom Jul 30, 2017
kritzcreek:purs-ide-editor-modekritzcreek/purescript:purs-ide-editor-modeCopy head branch name to clipboard
Merged
[purs ide] Editor mode#3006kritzcreek merged 4 commits intopurescript:masterpurescript/purescript:masterfrom kritzcreek:purs-ide-editor-modekritzcreek/purescript:purs-ide-editor-modeCopy head branch name to clipboard
kritzcreek merged 4 commits intopurescript:masterpurescript/purescript:masterfrom
kritzcreek:purs-ide-editor-modekritzcreek/purescript:purs-ide-editor-modeCopy head branch name to clipboard
Conversation
When the editor-mode flag is specified at startup the server will not start a file watcher process anymore. Instead it only reloads after succesful rebuild commands. This is a lot less fragile than relying on the file system APIs, but will mean that a manual load needs to be triggered after builds that didn't go through purs ide. * Also updates the README under psc-ide/ to be a bit more recent
4b0a9c7 to
5757cbc
Compare
Contributor
|
Is this different from |
Member
Author
|
Yeah, since it loads the parsed file and generated ExternsFile after rebuilding into the cache. Look at the change inside |
…f-thread This also makes the perf measurement mean something
5757cbc to
2606727
Compare
paf31
approved these changes
Jul 30, 2017
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new flag to the server invocation:
--editor-modeWhen the editor-mode flag is specified at startup the server will not start a file watcher process anymore. Instead it only reloads after successful rebuild commands. This is a lot less fragile than relying on the file system APIs, but will mean that a manual load needs to be triggered after builds that didn't go through purs ide.
Looking forward to get Feedback :) After using psc-ide more intensively the last months it seems like the file watcher is the most fragile part of the system so I'm looking for ways to circumvent that problem.