Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

fnune
Copy link
Member

@fnune fnune commented Oct 9, 2025

Results like this:

Please choose a template (279 total):
 aws-go  [Use arrows to move, type to filter]
> aws-go                                                                              A minimal AWS Go Pulumi program
  aws-go                                                                              A minimal AWS Go Pulumi program
  container-aws-go                                                                    A Go program to deploy a containerized service on AWS
  ...

Are due to a package aws-go existing both in the Private Registry as well as elsewhere. This PR changes the description to result in something like this, so that users can tell them apart:

Please choose a template (279 total):
 aws-go  [Use arrows to move, type to filter]
> aws-go                                                                              A minimal AWS Go Pulumi program
  aws-go                                                                              [Private Registry] A minimal AWS Go Pulumi program
  container-aws-go                                                                    A Go program to deploy a containerized service on AWS
  ...

Results like this:

```
Please choose a template (279 total):
 aws-go  [Use arrows to move, type to filter]
> aws-go                                                                              A minimal AWS Go Pulumi program
  aws-go                                                                              A minimal AWS Go Pulumi program
  container-aws-go                                                                    A Go program to deploy a containerized service on AWS
  ...
```

Are due to a package `aws-go` existing both in the Private Registry as
well as elsewhere. This PR changes the description to result in
something like this, so that users can tell them apart:

```
Please choose a template (279 total):
 aws-go  [Use arrows to move, type to filter]
> aws-go                                                                              A minimal AWS Go Pulumi program
  aws-go                                                                              [Private Registry] A minimal AWS Go Pulumi program
  container-aws-go                                                                    A Go program to deploy a containerized service on AWS
  ...
```
@iwahbe
Copy link
Member

iwahbe commented Oct 9, 2025

I think it would be a better UX if all conflicting names had their source prefixed, and we didn't prefix otherwise. Looking at 2 copies of aws-go doesn't tell the user what the other copy is:

> aws-go [Private Registry]                minimal AWS Go Pulumi program
  aws-go                                   minimal AWS Go Pulumi program

I think this is much clearer

> aws-go [pulumi/private]                           minimal AWS Go Pulumi program
  aws-go [github.com/pulumi/templates]              minimal AWS Go Pulumi program

On top of @fnune's work here #20701

The `Template` interface used in the UI does not need to concern itself
with project description vs template description vs display description.
We can simplify the interface and drop some of the confusing properties
used to determine the template description.
@julienp julienp marked this pull request as ready for review October 13, 2025 09:42
@julienp julienp requested a review from a team as a code owner October 13, 2025 09:42
@julienp
Copy link
Contributor

julienp commented Oct 13, 2025

I merged a simplification of the UI representation of a template into this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.