Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

vivado xsim : add XILINX_SIMULATOR ifdefs replace XSIM ifdef#264

Draft
skokvermon wants to merge 1 commit intopulp-platform:masterpulp-platform/axi:masterfrom
skokvermon:fuse_xsimskokvermon/axi:fuse_xsimCopy head branch name to clipboard
Draft

vivado xsim : add XILINX_SIMULATOR ifdefs replace XSIM ifdef#264
skokvermon wants to merge 1 commit intopulp-platform:masterpulp-platform/axi:masterfrom
skokvermon:fuse_xsimskokvermon/axi:fuse_xsimCopy head branch name to clipboard

Conversation

@skokvermon
Copy link
Copy Markdown
Contributor

@skokvermon skokvermon commented Sep 27, 2022

replace XSIM ifdef by XILINX_SIMULATOR as described in https://docs.xilinx.com/r/en-US/ug900-vivado-logic-simulation/Predefined-Macros
depends on pulp-platform/common_cells#139

Some more benchs are working

However there are segfaults on a lot of them.

@skokvermon skokvermon mentioned this pull request Sep 27, 2022
Merged
@thommythomaso
Copy link
Copy Markdown
Collaborator

thommythomaso commented Sep 28, 2022

We have internally discussed this matter. We can change XSIM to XILINX_SIMULATOR and guard/implement alternatives to make the TBs work in xsim if:

  • the changes happening globally and in the dependencies first, e.g., change XSIM to XILINX_SIMULATOR in common_cells first
  • the testbenches (or most of them) do run
  • the target is for sure not used in fusesoc for a different purpose (as XSIMwas introduced by olofk)
  • the code of the testbench will not look too fragmented due to too many ifdefs

@thommythomaso thommythomaso mentioned this pull request Sep 28, 2022
Closed
@thommythomaso thommythomaso marked this pull request as draft December 10, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skokvermon @thommythomaso
Morty Proxy This is a proxified and sanitized view of the page, visit original site.