Version 4.2.0#81
Merged
Conversation
…s to support v2 signatures and /v2 endpoints.
PAMv3 feature
Merge branch
Version 4.1.8
davidnub
reviewed
Dec 27, 2019
.pubnub.yml
Outdated
| @@ -1,8 +1,21 @@ | ||
| name: python | ||
| version: 4.1.7 | ||
| version: 4.1.8 |
Contributor
There was a problem hiding this comment.
This is a pretty big feature, should probably be 4.2.0
davidnub
reviewed
Dec 27, 2019
CHANGELOG.md
Outdated
| @@ -1,3 +1,13 @@ | ||
| ## [4.1.8](https://github.com/pubnub/python/tree/v4.1.8) |
Contributor
There was a problem hiding this comment.
This is a pretty big feature, should probably be 4.2.0
davidnub
reviewed
Dec 27, 2019
setup.py
Outdated
| setup( | ||
| name='pubnub', | ||
| version='4.1.7', | ||
| version='4.1.8', |
Contributor
There was a problem hiding this comment.
This is a pretty big feature, should probably be 4.2.0
davidnub
approved these changes
Dec 27, 2019
Contributor
davidnub
left a comment
There was a problem hiding this comment.
LGTM. 🎉 Would prefer the minor version gets bumped though.
Contributor
|
Should probably resolve the Codacy errors as well. |
- David
|
Issues
======
+ Solved 1
- Added 7
Complexity increasing per file
==============================
- pubnub/models/consumer/v3/access_manager.py 1
- pubnub/pubnub_asyncio.py 1
- pubnub/models/consumer/v3/pn_resource.py 2
- pubnub/models/consumer/v3/space.py 1
- pubnub/endpoints/access/grant.py 2
- pubnub/models/consumer/v3/user.py 1
- pubnub/models/consumer/v3/group.py 1
- pubnub/endpoints/access/grant_token.py 5
- pubnub/models/consumer/v3/channel.py 1
- pubnub/utils.py 5
- pubnub/managers.py 1
- pubnub/endpoints/endpoint.py 1
Complexity decreasing per file
==============================
+ tests/integrational/asyncio/test_pam.py -4
Clones added
============
- pubnub/pubnub.py 2
- pubnub/models/consumer/v3/space.py 1
- pubnub/endpoints/access/grant.py 1
- pubnub/models/consumer/v3/user.py 1
- pubnub/endpoints/access/audit.py 1
- pubnub/endpoints/access/grant_token.py 1
Clones removed
==============
+ tests/integrational/asyncio/test_pam.py -8
See the complete overview on Codacy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 4.1.8