Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Run tests for python-3.7 in travis#69

Closed
gonzalobf wants to merge 3 commits intopubnub:masterpubnub/python:masterfrom
gonzalobf:run-python37-travisgonzalobf/python:run-python37-travisCopy head branch name to clipboard
Closed

Run tests for python-3.7 in travis#69
gonzalobf wants to merge 3 commits intopubnub:masterpubnub/python:masterfrom
gonzalobf:run-python37-travisgonzalobf/python:run-python37-travisCopy head branch name to clipboard

Conversation

@gonzalobf
Copy link

@gonzalobf gonzalobf commented Mar 13, 2019

I just realized that the library supports python3.7 but it is not tested with this version in travis

@gonzalobf
Copy link
Author

Flake8 is failing for code that is already commit in master. I can fix it here or wait until #68 is merged. I would be happy to wait and rebase my branch once #68 is merge but I don't if it will be merged soon.

Thank you

@qsoftdevelopment
Copy link
Contributor

@gonzalobf Can you wait a couple of days as we are releasing a new version? It will have conflicts with your current code.
Python 3.7 is supported and we will resolve possible issues with it.

@gonzalobf
Copy link
Author

@qsoftdevelopment yes sure, thank you.

@gonzalobf gonzalobf force-pushed the run-python37-travis branch from 9b28b38 to a6ce0d2 Compare March 20, 2019 09:26
@gonzalobf gonzalobf force-pushed the run-python37-travis branch from a6ce0d2 to 9786aea Compare March 20, 2019 10:19
@qsoftdevelopment
Copy link
Contributor

@gonzalobf Can you try now with the latest Python SDK?

@qsoftdevelopment
Copy link
Contributor

@gonzalobf We have detected the problem. It's the issue with the outdated library. This is not a quick fix and we should have the fix in the next Python SDK release.

@gonzalobf
Copy link
Author

@qsoftdevelopment I rebased my branch to v4.1.4 branch and run tests locally. Asyncio tests still failing, so I'm not totally sure if it is fixed in that version.

…om pypi.

Vcrpy pubnub version hasn't been updated in years and it doesn't support python 3.7
yield from was raising `TypeError: cannot 'yield from' a coroutine object in a non-coroutine generator` and
using await with async (as pytest-asyncio suggested) fixed the problem.
@qsoftdevelopment
Copy link
Contributor

Hi @gonzalobf ,

V4.1.1 is pending release. In the meantime, you can check develop branch (https://github.com/pubnub/python/tree/develop) as it will be in v4.1.4. It should fix your problem. Let me know if it does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.