Expoential as a default reconnection policy#196
Expoential as a default reconnection policy#196seba-aln merged 8 commits intomasterpubnub/python:masterfrom feat/exponential-reconnect-by-defaultpubnub/python:feat/exponential-reconnect-by-defaultCopy head branch name to clipboard
Conversation
42b26a3 to
b9db664
Compare
| self._timer = None | ||
|
|
||
|
|
||
| class LinearDelay: |
There was a problem hiding this comment.
Is it possible to provide custom delay other than 2?
There was a problem hiding this comment.
No, not really. Should we add this option?
There was a problem hiding this comment.
added in latest commit. thanks for pointing that out ;)
| def _register_heartbeat_timer(self): | ||
| self.stop_heartbeat_timer() | ||
|
|
||
| if self._retry_limit_reached(): |
There was a problem hiding this comment.
I don't know how it works in Python, but should announcing disconnected status being part of EE?
There was a problem hiding this comment.
No. This one is for non-event engine subscribe (yeah, python has more than one subscribe)
| @when('I subscribe with timetoken {timetoken}') | ||
| def step_impl(context: PNContext, timetoken: str): # noqa F811 | ||
| @async_run_until_complete | ||
| async def step_impl(context: PNContext, timetoken: str): # noqa F811 |
There was a problem hiding this comment.
I'm curious, what it means? # noqa F811
There was a problem hiding this comment.
it disables validation errors upon redeclaration of method. in this file there are more methods called step_impl, but they are the content of a @when decorator. so TL:DR - 'tis just for linter
bcc837f to
b6746db
Compare
No description provided.