Immutable locking config#189
Merged
seba-aln merged 5 commits intomasterpubnub/python:masterfrom Aug 8, 2024
feat/immutable-pnconfigurationpubnub/python:feat/immutable-pnconfigurationCopy head branch name to clipboard
Merged
Immutable locking config#189seba-aln merged 5 commits intomasterpubnub/python:masterfrom feat/immutable-pnconfigurationpubnub/python:feat/immutable-pnconfigurationCopy head branch name to clipboard
seba-aln merged 5 commits intomasterpubnub/python:masterfrom
feat/immutable-pnconfigurationpubnub/python:feat/immutable-pnconfigurationCopy head branch name to clipboard
Conversation
wkal-pubnub
reviewed
Aug 2, 2024
| self.config = config | ||
| def __init__(self, config: PNConfiguration): | ||
| if not config.disable_config_locking: | ||
| config.lock() |
There was a problem hiding this comment.
if, as a user, I wanted to reuse most of the settings of the config to create a new (second) PN instance, is there a way I can do it now? probably not, since the original config will be locked (both outside and the inner copy in PN)?
Can you add a method to config that, even with a locked config, lets me clone+modify an existing config? or is it already possible with some Python magic, or similar to the deepcopy function that you're using here
I'd like to do something like (pseudocode):
val config = PNConfiguration(blah, blah, blah)
val pubnub1 = PubNub(config)
val config2 = config.copy(uuid = blah2)
val pubnub2 = PubNub(config2)
2a20d99 to
e97e0f6
Compare
wkal-pubnub
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Optionally immutable config.
Option to lock PNConfiguration mutability. Note that mutable config will be deprecated in future major releases