Add missing history_with_actions fields#117
Merged
seba-aln merged 3 commits intomasterpubnub/python:masterfrom Apr 11, 2022
fix/add-missing-history-fieldspubnub/python:fix/add-missing-history-fieldsCopy head branch name to clipboard
Merged
Add missing history_with_actions fields#117seba-aln merged 3 commits intomasterpubnub/python:masterfrom fix/add-missing-history-fieldspubnub/python:fix/add-missing-history-fieldsCopy head branch name to clipboard
seba-aln merged 3 commits intomasterpubnub/python:masterfrom
fix/add-missing-history-fieldspubnub/python:fix/add-missing-history-fieldsCopy head branch name to clipboard
Conversation
61d8721 to
8e17153
Compare
8e17153 to
37ab538
Compare
kleewho
reviewed
Mar 30, 2022
kleewho
left a comment
There was a problem hiding this comment.
I can't tell why, but we have something like this in Java SDK:
@SerializedName("message_type")
@Getter(AccessLevel.NONE)
private final String messageType;
private int getMessageType() {
if (messageType == null || messageType.isEmpty()) {
return 0;
} else {
return Integer.parseInt(messageType);
}
}
Which means that if message type is not set the default that the SDK user see is 0. I'll try to find a ticket or something that maybe tell us more
| self._count = None | ||
| self._include_meta = None | ||
| self._include_message_actions = None | ||
| self._include_message_type = None |
There was a problem hiding this comment.
I don't think we have it in Kotlin SDK :/
Author
There was a problem hiding this comment.
i've included all fields that were required to completely mimic the behavior of REST endpoint
kleewho
approved these changes
Mar 30, 2022
Author
|
@client-engineering-bot release |
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add methods to include additional fields in fetch_messages