Call ready() if document already loaded#9
Closed
jonmumm wants to merge 1 commit intopubnub:masterpubnub/javascript:masterfrom
Closed
Call ready() if document already loaded#9jonmumm wants to merge 1 commit intopubnub:masterpubnub/javascript:masterfrom
jonmumm wants to merge 1 commit intopubnub:masterpubnub/javascript:masterfrom
Conversation
|
@jonmumm thanks for the contribution! We are finalizing a push for JS right now -- this pull request will be considered for our next sprint. Don't forget to email support@pubnub.com to get your PubNub T-Shirt! |
Member
|
reviewing... |
Member
|
We merged this. This is now available in the latest version. |
ghost
pushed a commit
that referenced
this pull request
Nov 18, 2021
fix: fix compatibility with Salesforce Lock console One of components forced `webpack` to use shim for Buffer. This components was `cbor-sync` module to decode PubNub PAMv3 tokens. To avoid this, `cbor-js` has been added and used for web version of PubNub SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just realized you could call pubnub.ready() directly, however this change makes it so you don't have to if the document is already loaded.