Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix/prevent retry for non retryable 404 status code#488

Merged
mohitpubnub merged 10 commits intomasterpubnub/javascript:masterfrom
fix/prevent-retry-nonRetryablepubnub/javascript:fix/prevent-retry-nonRetryableCopy head branch name to clipboard
Jan 13, 2026
Merged

Fix/prevent retry for non retryable 404 status code#488
mohitpubnub merged 10 commits intomasterpubnub/javascript:masterfrom
fix/prevent-retry-nonRetryablepubnub/javascript:fix/prevent-retry-nonRetryableCopy head branch name to clipboard

Conversation

@mohitpubnub
Copy link
Contributor

@mohitpubnub mohitpubnub commented Jan 12, 2026

refactor: prevent retry on http status code 404.

Prevent retry when response is having http status code 404.

@mohitpubnub mohitpubnub requested a review from parfeon as a code owner January 12, 2026 14:04
@pubnub-ops-terraform
Copy link

pubnub-ops-terraform commented Jan 12, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@mohitpubnub mohitpubnub self-assigned this Jan 12, 2026
@mohitpubnub mohitpubnub added status: done This issue is considered resolved. priority: medium This PR should be reviewed after all high priority PRs. labels Jan 12, 2026
@mohitpubnub mohitpubnub changed the title Fix/prevent retry non retryable Fix/prevent retry for non retryable 404 status code Jan 12, 2026
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohitpubnub
Copy link
Contributor Author

@pubnub-release-bot release

@mohitpubnub mohitpubnub merged commit 32cc0bd into master Jan 13, 2026
9 checks passed
@mohitpubnub mohitpubnub deleted the fix/prevent-retry-nonRetryable branch January 13, 2026 09:53
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.