Clearing poll timeouts on _reset_offline, so no handles are left open when there are no receivers registered.#40
Closed
josdejong wants to merge 1 commit intopubnub:developpubnub/javascript:developfrom
Closed
Clearing poll timeouts on _reset_offline, so no handles are left open when there are no receivers registered.#40josdejong wants to merge 1 commit intopubnub:developpubnub/javascript:developfrom
josdejong wants to merge 1 commit intopubnub:developpubnub/javascript:developfrom
Conversation
… when there are no receivers registered.
e24ae79 to
f4f178a
Compare
Contributor
|
as javascript web / node v4 was released to stable with a fully rewritten core, we are closing up v3.0 based requests as we move v3 into maintenance mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearing poll timeouts on _reset_offline, so no handles are left open when there are no receivers registered. Without this, pubnub cannot be unloaded: these timeouts are running forever and the node.js process cannot exist or garbage collect pubnub.