Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: wrong error interface in RN#305

Merged
are merged 3 commits intomasterpubnub/javascript:masterfrom
fix/CLEN-893pubnub/javascript:fix/CLEN-893Copy head branch name to clipboard
Dec 13, 2022
Merged

fix: wrong error interface in RN#305
are merged 3 commits intomasterpubnub/javascript:masterfrom
fix/CLEN-893pubnub/javascript:fix/CLEN-893Copy head branch name to clipboard

Conversation

@are
Copy link
Contributor

@are are commented Dec 9, 2022

fix: fix wrong error interface in RN

Fixes a case in React Native with using an error interface in superagent.

fix: getFileUrl construct proper url when token is set.

Fixes issue of getFileUrl not setting auth value as token string when token is set.

Closes #302

@are are added priority: high This PR should be reviewed ASAP. type: fix This PR contains fixes to existing features. labels Dec 9, 2022
Copy link
Contributor

@mohitpubnub mohitpubnub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we combine PR #304 with this for the release?

@are
Copy link
Contributor Author

are commented Dec 12, 2022

@mohitpubnub yes, lets do that!

@mohitpubnub
Copy link
Contributor

@are

  • changes merged.
  • PR description updated.

@are
Copy link
Contributor Author

are commented Dec 12, 2022

@client-engineering-bot release as v7.2.2

@are are merged commit ffdb745 into master Dec 13, 2022
@are are deleted the fix/CLEN-893 branch December 13, 2022 09:43
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: high This PR should be reviewed ASAP. type: fix This PR contains fixes to existing features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_file_url should support both token manager token and auth key like other endpoints

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.