Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

ref/memberships#277

Merged
mohitpubnub merged 22 commits intomasterpubnub/javascript:masterfrom
ref/membershipspubnub/javascript:ref/membershipsCopy head branch name to clipboard
Jun 14, 2022
Merged

ref/memberships#277
mohitpubnub merged 22 commits intomasterpubnub/javascript:masterfrom
ref/membershipspubnub/javascript:ref/membershipsCopy head branch name to clipboard

Conversation

@mohitpubnub
Copy link
Contributor

@mohitpubnub mohitpubnub commented May 27, 2022 •
edited
Loading

feat: Added membership apis

Added user and space memberships related methods.

feat: Added type and status fields.

Added type and status fields in User and Space. status field in memberships.

@mohitpubnub
Copy link
Contributor Author

mohitpubnub commented May 27, 2022

WiP fetchMemberships

@are
Copy link
Contributor

are commented May 27, 2022

Oh, you have to remember that we cannot remove or change any existing methods. (the remove -> delete should be fine)

@mohitpubnub
Copy link
Contributor Author

mohitpubnub commented May 30, 2022

Oh, you have to remember that we cannot remove or change any existing methods. (the remove -> delete should be fine)

Yes,
apart from that it has following changes

  • status field in membership api's patch payload.
  • if (params?.limit)) returns false with integer 0 param value of limit which we set default with add/update memberships. So it has to check for null

@mohitpubnub mohitpubnub requested a review from Salet June 7, 2022 11:38
@mohitpubnub mohitpubnub added status: done This issue is considered resolved. type: feature This PR contains new feature. labels Jun 7, 2022
@mohitpubnub mohitpubnub added the type: refactor This PR contains refactored existing features. label Jun 7, 2022
@mohitpubnub
* default include status and type fields in get,set,getAll.
65d3658 
* Fixed tests
* Minor indentation changes in changed files.
@mohitpubnub
build files
c04151c
@mohitpubnub
* event listener for user, space and membership event types.
da5fc83 
* refactored dead listeners which were not emitting any events for user and space type.
@mohitpubnub
Copy link
Contributor Author

mohitpubnub commented Jun 14, 2022

@client-engineering-bot release as v7.1.1

@mohitpubnub mohitpubnub merged commit f09df2b into master Jun 14, 2022
@mohitpubnub mohitpubnub deleted the ref/memberships branch June 14, 2022 15:28
@github-actions
Copy link

github-actions bot commented Jun 14, 2022

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazydek kazydek kazydek approved these changes

@phairow phairow Awaiting requested review from phairow

@parfeon parfeon Awaiting requested review from parfeon parfeon is a code owner

@Salet Salet Awaiting requested review from Salet

@techwritermat techwritermat Awaiting requested review from techwritermat techwritermat is a code owner

+1 more reviewer

@are are are approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: done This issue is considered resolved. type: feature This PR contains new feature. type: refactor This PR contains refactored existing features.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohitpubnub @are @kazydek
Morty Proxy This is a proxified and sanitized view of the page, visit original site.