Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix export for cjs and es module compatibility#276

Merged
phairow merged 5 commits intomasterpubnub/javascript:masterfrom
nodejs-ts-buildpubnub/javascript:nodejs-ts-buildCopy head branch name to clipboard
May 24, 2022
Merged

fix export for cjs and es module compatibility#276
phairow merged 5 commits intomasterpubnub/javascript:masterfrom
nodejs-ts-buildpubnub/javascript:nodejs-ts-buildCopy head branch name to clipboard

Conversation

@phairow
Copy link
Contributor

@phairow phairow commented May 24, 2022

  1. add "esModuleInterop": true, to tsconfig
  2. rename node/index.js to node/index.ts
  3. export = class extends PubNubCore {
  4. add types in the ts file for parameters
  • constructor(setup: any) {
  • (base64String: string)

@are
Copy link
Contributor

are commented May 24, 2022

@client-engineering-bot release as v7.0.1

@phairow phairow merged commit 26d6baf into master May 24, 2022
@phairow phairow deleted the nodejs-ts-build branch May 24, 2022 18:27
@github-actions
Copy link

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.